bug report in String.hashCode()

[Archie Cobbs]

Per Bothner writes:
> > +	boolean hashIsValid;
> > +	int hash;
> > ...
> > +	if (!hashIsValid) {
> > ...
> > +		hashIsValid = true;
> 
> To safe one word in each String, I would suggest:
> 
> 	if (hash == 0 && count > 0)
> 		...
> 
> Very unlikely that you will need to calculate the hash more than once.

Sure.. if you're willing to live with that 1/2^32 chance... :-)

I think you're right. On average you're more likely to go slower because
of extra memory use (-> swapping) than you are because of hitting strings
like "bmgi~ds"...

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com