[kaffe] Jar files in 1.1.3?

[Mark Wielaard]

Hi,

On Thu, 2003-12-11 at 16:18, Casey Marshall wrote:
> >>>>> "Ito" == Ito Kazumitsu <ito.kazumitsu at hitachi-cable.co.jp> writes:
> 
> Ito> In message "Re: [kaffe] Jar files in 1.1.3?"  on 03/12/10, Casey
> Ito> Marshall <rsdio at metastatic.org> writes:
> 
> >> The problem is with kaffe.tools.jar.Jar. Line 1053.
> 
> Ito> I have not studied kaffe/tools/jar/Jar.java yet.  But I could
> Ito> reproduce the error.  It seems that this error occurs when the
> Ito> files to be archived are not directories but ordinary files.
> 
> To me, it looks as though Jar.java was written for a different version
> of the java.util.jar classes (Classpath's versions were recently
> merged, right?) and they explictly put the "Name" attribute.
> 
> Classpath's Manifest class writes "Name" attributes automatically, so
> I think Kaffe's Jar is wrong.
> 
> The fix is trivial, and attached.

I believe Casey his analysis is correct. If that doesn't fix the problem
then please let me know (I wrote java.util.jar a long time ago so it
could certainly be a bug in that code, but I believe it is indeed a bug
in the Jar tool).

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://kaffe.org/pipermail/kaffe/attachments/20031227/4e03a62e/attachment-0002.pgp