[kaffe] Jar files in 1.1.3?
guilhem at kaffe.org
Sun Dec 28 00:56:01 PST 2003
Casey Marshall wrote:
> >>>>>"Mark" == Mark Wielaard <mark at klomp.org> writes:
> Mark> Hi,
> Mark> On Thu, 2003-12-11 at 16:18, Casey Marshall wrote:
> >>>>>>>"Ito" == Ito Kazumitsu <ito.kazumitsu at hitachi-cable.co.jp>
> Ito> In message "Re: [kaffe] Jar files in 1.1.3?" on 03/12/10, Casey
> Ito> Marshall <rsdio at metastatic.org> writes:
> >> >> The problem is with kaffe.tools.jar.Jar. Line 1053.
> Ito> I have not studied kaffe/tools/jar/Jar.java yet. But I could
> Ito> reproduce the error. It seems that this error occurs when the
> Ito> files to be archived are not directories but ordinary files.
> >> To me, it looks as though Jar.java was written for a different
> >>version of the java.util.jar classes (Classpath's versions were
> >>recently merged, right?) and they explictly put the "Name"
> >>Classpath's Manifest class writes "Name" attributes automatically,
> >>so I think Kaffe's Jar is wrong.
> >>The fix is trivial, and attached.
> Mark> I believe Casey his analysis is correct. If that doesn't fix the
> Mark> problem then please let me know (I wrote java.util.jar a long
> Mark> time ago so it could certainly be a bug in that code, but I
> Mark> believe it is indeed a bug in the Jar tool).
> That little fix still doesn't quite give a usable jar tool, however.
> When individual files are given on the command line, they are not
> stored with relative directories.
> That is, trying to put a file `foo/bar/baz' into a jar file will
> result in just `baz' in the jar, without the directory structure.
Strange. I've just tested your patch and now everything is fine on my
computer. Anyway, I've put your patch in the CVS.
More information about the kaffe