No subject


Mon Jun 21 19:03:09 PDT 2004


int ipadx                                                                   
   This field specifies the internal padding of the component,        
   how much space to add to the minimum width of the component.                 

java.awt.GridBagLayout used to interpret ipadx and ipady as values added
to the insets, so increasing ipadx increases the size around the
component, not the component itself.

I've attached a patch fixing this broken behaviour and a test program.

The test program still shows some difference between JDK and Kaffe,
supposedly due to strange (or broken) implementation of preferredSize()
in java.awt.Frame

Pavel Roskin

--96667023-1848547842-929689386=:6274
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="GridBagEx1.java"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.10.9906181103060.6274 at proxy.typhoon.spb.ru>
Content-Description: 
Content-Disposition: attachment; filename="GridBagEx1.java"

aW1wb3J0IGphdmEuYXd0Lio7DQppbXBvcnQgamF2YS51dGlsLio7DQppbXBv
cnQgamF2YS5hcHBsZXQuQXBwbGV0Ow0KDQpwdWJsaWMgY2xhc3MgR3JpZEJh
Z0V4MSBleHRlbmRzIEFwcGxldCB7DQoNCglwdWJsaWMgdm9pZCBpbml0KCkg
ew0KCQlHcmlkQmFnTGF5b3V0IGdyaWRiYWcgPSBuZXcgR3JpZEJhZ0xheW91
dCgpOw0KCQlHcmlkQmFnQ29uc3RyYWludHMgYyA9IG5ldyBHcmlkQmFnQ29u
c3RyYWludHMoKTsNCg0KCQlzZXRMYXlvdXQoZ3JpZGJhZyk7DQoNCgkJYy5p
cGFkeCA9IDE1MDsNCgkJQnV0dG9uIGJ1dHRvbiA9IG5ldyBCdXR0b24oIkhl
bGxvIik7DQoJCWdyaWRiYWcuc2V0Q29uc3RyYWludHMoYnV0dG9uLCBjKTsN
CgkJYWRkKGJ1dHRvbik7DQoNCgkJc2V0U2l6ZSg0MDAsIDMwMCk7DQoJfQ0K
DQoJcHVibGljIHN0YXRpYyB2b2lkIG1haW4oU3RyaW5nIGFyZ3NbXSkgew0K
CQlGcmFtZSBmID0gbmV3IEZyYW1lKCJHcmlkQmFnIExheW91dCBFeGFtcGxl
Iik7DQoJCUdyaWRCYWdFeDEgZXgxID0gbmV3IEdyaWRCYWdFeDEoKTsNCg0K
CQlleDEuaW5pdCgpOw0KDQoJCWYuYWRkKCJDZW50ZXIiLCBleDEpOw0KCQlm
LnBhY2soKTsNCgkJZi5zZXRTaXplKGYuZ2V0UHJlZmVycmVkU2l6ZSgpKTsN
CgkJZi5zaG93KCk7DQoJfQ0KfQ0K
--96667023-1848547842-929689386=:6274
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ipad.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.10.9906181103061.6274 at proxy.typhoon.spb.ru>
Content-Description: 
Content-Disposition: attachment; filename="ipad.diff"

SW5kZXg6IGxpYnJhcmllcy9qYXZhbGliL2phdmEvYXd0L0dyaWRCYWdMYXlv
dXQuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9o
b21lL2N2c3B1YmxpYy9rYWZmZS9saWJyYXJpZXMvamF2YWxpYi9qYXZhL2F3
dC9HcmlkQmFnTGF5b3V0LmphdmEsdg0KcmV0cmlldmluZyByZXZpc2lvbiAx
LjkNCmRpZmYgLXUgLXIxLjkgR3JpZEJhZ0xheW91dC5qYXZhDQotLS0gR3Jp
ZEJhZ0xheW91dC5qYXZhCTE5OTkvMDYvMTMgMjI6Mjk6MjcJMS45DQorKysg
R3JpZEJhZ0xheW91dC5qYXZhCTE5OTkvMDYvMTcgMjM6MzU6NTANCkBAIC0y
MTQsOCArMjE0LDggQEANCiAJCQl5ID0gY2MuZ3JpZHk7DQogCQl9DQogDQot
CQlpbnQgY3cgPSBjZC53aWR0aCArIGNjLmluc2V0cy5sZWZ0ICsgY2MuaW5z
ZXRzLnJpZ2h0ICsgMiAqIGNjLmlwYWR4Ow0KLQkJaW50IGNoID0gY2QuaGVp
Z2h0ICsgY2MuaW5zZXRzLnRvcCArIGNjLmluc2V0cy5ib3R0b20gKyAyICog
Y2MuaXBhZHk7DQorCQlpbnQgY3cgPSBjZC53aWR0aCArIGNjLmluc2V0cy5s
ZWZ0ICsgY2MuaW5zZXRzLnJpZ2h0ICsgY2MuaXBhZHg7DQorCQlpbnQgY2gg
PSBjZC5oZWlnaHQgKyBjYy5pbnNldHMudG9wICsgY2MuaW5zZXRzLmJvdHRv
bSArIGNjLmlwYWR5Ow0KIAkJDQogCQlpbnQgZ3cgPSBjYy5ncmlkd2lkdGg7
DQogCQlpbnQgZ2ggPSBjYy5ncmlkaGVpZ2h0Ow0KQEAgLTQzMCwyMCArNDMw
LDIwIEBADQogCQlEaW1lbnNpb24gY2QgPSBjLmdldFByZWZlcnJlZFNpemUo
KTsNCiAJCWludCBjeCA9IHggKyBvZmZzZXQueDsNCiAJCWludCBjeSA9IHkg
KyBvZmZzZXQueTsNCi0JCWludCBjdyA9IGNkLndpZHRoOw0KLQkJaW50IGNo
ID0gY2QuaGVpZ2h0Ow0KKwkJaW50IGN3ID0gY2Qud2lkdGggKyBjYy5pcGFk
eDsNCisJCWludCBjaCA9IGNkLmhlaWdodCArIGNjLmlwYWR5Ow0KIA0KIAkJ
c3dpdGNoICggY2MuZmlsbCApIHsNCiAJCWNhc2UgY2MuQk9USDoNCi0JCQlj
eCArPSBpbi5sZWZ0ICsgY2MuaXBhZHg7DQotCQkJY3kgKz0gaW4udG9wICsg
Y2MuaXBhZHk7DQotCQkJY3cgPSBkeCAtIChpbi5sZWZ0ICsgaW4ucmlnaHQg
KyAyICogY2MuaXBhZHgpOw0KLQkJCWNoID0gZHkgLSAoaW4udG9wICsgaW4u
Ym90dG9tICsgMiAqIGNjLmlwYWR5KTsNCisJCQljeCArPSBpbi5sZWZ0Ow0K
KwkJCWN5ICs9IGluLnRvcDsNCisJCQljdyA9IGR4IC0gKGluLmxlZnQgKyBp
bi5yaWdodCk7DQorCQkJY2ggPSBkeSAtIChpbi50b3AgKyBpbi5ib3R0b20p
Ow0KIAkJCWJyZWFrOw0KIA0KIAkJY2FzZSBjYy5IT1JJWk9OVEFMOg0KLQkJ
CWN4ICs9IGluLmxlZnQgKyBjYy5pcGFkeDsNCi0JCQljdyA9IGR4IC0gKGlu
LmxlZnQgKyBpbi5yaWdodCArIDIgKiBjYy5pcGFkeCk7DQorCQkJY3ggKz0g
aW4ubGVmdDsNCisJCQljdyA9IGR4IC0gKGluLmxlZnQgKyBpbi5yaWdodCk7
DQogCQkJc3dpdGNoICggY2MuYW5jaG9yICkgew0KIAkJCWNhc2UgY2MuV0VT
VDoNCiAJCQljYXNlIGNjLkNFTlRFUjoNCkBAIC00NTUsMjAgKzQ1NSwyMCBA
QA0KIAkJCWNhc2UgY2MuTk9SVEg6DQogCQkJY2FzZSBjYy5OT1JUSEVBU1Q6
DQogCQkJY2FzZSBjYy5OT1JUSFdFU1Q6DQotCQkJCWN5ICs9IGluLnRvcCAr
IGNjLmlwYWR5Ow0KKwkJCQljeSArPSBpbi50b3A7DQogCQkJCWJyZWFrOw0K
IA0KIAkJCWNhc2UgY2MuU09VVEhFQVNUOg0KIAkJCWNhc2UgY2MuU09VVEg6
DQogCQkJY2FzZSBjYy5TT1VUSFdFU1Q6DQotCQkJCWN5ICs9IGR5IC0gKGNk
LmhlaWdodCArIGluLmJvdHRvbSArIGNjLmlwYWR5KTsNCisJCQkJY3kgKz0g
ZHkgLSAoY2QuaGVpZ2h0ICsgaW4uYm90dG9tKTsNCiAJCQkJYnJlYWs7DQog
CQkJfQ0KIAkJCWJyZWFrOw0KIA0KIAkJY2FzZSBjYy5WRVJUSUNBTDoNCi0J
CQljeSArPSBpbi50b3AgKyBjYy5pcGFkeTsNCi0JCQljaCA9IGR5IC0gKGlu
LnRvcCArIGluLmJvdHRvbSArIDIgKiBjYy5pcGFkeSk7DQorCQkJY3kgKz0g
aW4udG9wOw0KKwkJCWNoID0gZHkgLSAoaW4udG9wICsgaW4uYm90dG9tKTsN
CiAJCQlzd2l0Y2ggKCBjYy5hbmNob3IgKSB7DQogCQkJY2FzZSBjYy5OT1JU
SDoNCiAJCQljYXNlIGNjLkNFTlRFUjoNCkBAIC00ODAsMTMgKzQ4MCwxMyBA
QA0KIAkJCWNhc2UgY2MuTk9SVEhXRVNUOg0KIAkJCWNhc2UgY2MuV0VTVDoN
CiAJCQljYXNlIGNjLlNPVVRIV0VTVDoNCi0JCQkJY3ggKz0gaW4ubGVmdCAr
IGNjLmlwYWR4Ow0KKwkJCQljeCArPSBpbi5sZWZ0Ow0KIAkJCQlicmVhazsN
CiANCiAJCQljYXNlIGNjLk5PUlRIRUFTVDoNCiAJCQljYXNlIGNjLlNPVVRI
RUFTVDoNCiAJCQljYXNlIGNjLkVBU1Q6DQotCQkJCWN4ICs9IGR4IC0gKGN3
ICsgaW4ucmlnaHQgKyBjYy5pcGFkeCk7DQorCQkJCWN4ICs9IGR4IC0gKGN3
ICsgaW4ucmlnaHQpOw0KIAkJCQlicmVhazsNCiAJCQl9DQogCQkJYnJlYWs7
DQpAQCAtNDk1LDQzICs0OTUsNDMgQEANCiAJCWRlZmF1bHQ6DQogCQkJc3dp
dGNoICggY2MuYW5jaG9yICkgew0KIAkJCWNhc2UgY2MuTk9SVEg6DQotCQkJ
CWN5ICs9IGluLnRvcCArIGNjLmlwYWR5Ow0KKwkJCQljeSArPSBpbi50b3A7
DQogCQkJCWN4ICs9IChkeCAtIGN3KSAvIDI7DQogCQkJCWJyZWFrOw0KIA0K
IAkJCWNhc2UgY2MuTk9SVEhFQVNUOg0KLQkJCQljeSArPSBpbi50b3AgKyBj
Yy5pcGFkeTsNCi0JCQkJY3ggKz0gZHggLSAoY3cgKyBpbi5yaWdodCArIGNj
LmlwYWR4KTsNCisJCQkJY3kgKz0gaW4udG9wOw0KKwkJCQljeCArPSBkeCAt
IChjdyArIGluLnJpZ2h0KTsNCiAJCQkJYnJlYWs7DQogDQogCQkJY2FzZSBj
Yy5FQVNUOg0KIAkJCQljeSArPSAoZHkgLSBjaCkgLyAyOw0KLQkJCQljeCAr
PSBkeCAtIChjdyArIGluLnJpZ2h0ICsgY2MuaXBhZHgpOw0KKwkJCQljeCAr
PSBkeCAtIChjdyArIGluLnJpZ2h0KTsNCiAJCQkJYnJlYWs7DQogDQogCQkJ
Y2FzZSBjYy5TT1VUSEVBU1Q6DQotCQkJCWN5ICs9IGR5IC0gKGNoICsgaW4u
Ym90dG9tICsgY2MuaXBhZHkpOw0KLQkJCQljeCArPSBkeCAtIChjdyArIGlu
LnJpZ2h0ICsgY2MuaXBhZHgpOw0KKwkJCQljeSArPSBkeSAtIChjaCArIGlu
LmJvdHRvbSk7DQorCQkJCWN4ICs9IGR4IC0gKGN3ICsgaW4ucmlnaHQpOw0K
IAkJCQlicmVhazsNCiANCiAJCQljYXNlIGNjLlNPVVRIOg0KLQkJCQljeSAr
PSBkeSAtIChjaCArIGluLmJvdHRvbSArIGNjLmlwYWR5KTsNCisJCQkJY3kg
Kz0gZHkgLSAoY2ggKyBpbi5ib3R0b20pOw0KIAkJCQljeCArPSAoZHggLSBj
dykgLyAyOw0KIAkJCQlicmVhazsNCiANCiAJCQljYXNlIGNjLlNPVVRIV0VT
VDoNCi0JCQkJY3kgKz0gZHkgLSAoY2ggKyBpbi5ib3R0b20gKyBjYy5pcGFk
eSk7DQotCQkJCWN4ICs9IGluLmxlZnQgKyBjYy5pcGFkeDsNCisJCQkJY3kg
Kz0gZHkgLSAoY2ggKyBpbi5ib3R0b20pOw0KKwkJCQljeCArPSBpbi5sZWZ0
Ow0KIAkJCQlicmVhazsNCiANCiAJCQljYXNlIGNjLldFU1Q6DQogCQkJCWN5
ICs9IChkeSAtIGNoKSAvIDI7DQotCQkJCWN4ICs9IGluLmxlZnQgKyBjYy5p
cGFkeDsNCisJCQkJY3ggKz0gaW4ubGVmdDsNCiAJCQkJYnJlYWs7DQogDQog
CQkJY2FzZSBjYy5OT1JUSFdFU1Q6DQotCQkJCWN5ICs9IGluLnRvcCArIGNj
LmlwYWR5Ow0KLQkJCQljeCArPSBpbi5sZWZ0ICsgY2MuaXBhZHg7DQorCQkJ
CWN5ICs9IGluLnRvcDsNCisJCQkJY3ggKz0gaW4ubGVmdDsNCiAJCQkJYnJl
YWs7DQogDQogCQkJY2FzZSBjYy5DRU5URVI6DQo=
--96667023-1848547842-929689386=:6274--


More information about the kaffe mailing list