[kaffe] warnings cleanup for amd64
eta at lclark.edu
Sun Apr 17 07:00:07 PDT 2005
On Sun, 2005-04-17 at 18:17 +0200, Guilhem Lavaux wrote:
> On Sat, 2005-04-16 at 13:13 -0700, Eric Anholt wrote:
> > Seeing only one regression failure on FreeBSD/amd64 (GCTest, which fails
> > 100% of the time), I went on another warnings cleanup spree. No
> > improvement in regressions, but fewer warnings as a result. It's mostly
> > type cleanups, but there's one uninitialized variable fix to jni.c which
> > looks important, and I think I set the correct initial value for it.
> > _______________________________________________
> > kaffe mailing list
> > kaffe at kaffe.org
> > http://kaffe.org/cgi-bin/mailman/listinfo/kaffe
> Hi Eric !
> I wonder why this patch is needed ? It obscures the type we really need.
> --- kaffe/kaffevm/intrp/icode.h 5 Feb 2005 09:22:42 -0000 1.23
> +++ kaffe/kaffevm/intrp/icode.h 17 Apr 2005 16:20:33 -0000
> @@ -16,7 +16,7 @@
> #include "soft.h"
> #if defined(KAFFE_VMDEBUG)
> -static const int32 UNINITIALIZED_STACK_SLOT = 0x00c0ffee;
> +static const long UNINITIALIZED_STACK_SLOT = 0x00c0ffee;
> I'm ok for the rest.
It was being compared to a pointer value at icode.h:341, and I thought
it was trying to be a relatively-unique pointer (though there would
probably be a better way of going about that).
Eric Anholt eta at lclark.edu
http://people.freebsd.org/~anholt/ anholt at FreeBSD.org
More information about the kaffe