[kaffe] CVS kaffe (guilhem): Fixlets.

[Marko Kreen]

On Fri, Dec 31, 2004 at 03:13:07AM -0800, Kaffe CVS wrote:
> Author: guilhem
>         * kaffe/kaffevm/jni/jni-string.c
>         (KaffeJNI_NewStringUTF): If data is NULL we should return NULL
>         directly.

I'm not familiar with Kaffe code, but:

  BEGIN_EXCEPTION_HANDLING(NULL);
  if (data == NULL)
    return NULL;

Isn't there END_EXCEPTION_HANDLING() missing?

And libraries/javalib/gnu/classpath/VMSystemProperties.java
does not check for getLocale() == null, so kaffe still crashes:

$ LANG=vi kaffe-cvs Test
Internal error: caught an unexpected exception.
Please check your CLASSPATH and your installation.
java/lang/NullPointerException
        at gnu.classpath.VMSystemProperties.preInit(VMSystemProperties.java:173)
        at gnu.classpath.SystemProperties.<clinit>(SystemProperties.java:68)
        at java.lang.System.<clinit>(System.java:43)
        at java.security.SecureClassLoader.<init>(SecureClassLoader.java:61)
        at java.net.URLClassLoader.<init>(URLClassLoader.java:548)
        at kaffe.lang.AppClassLoader.<init>(AppClassLoader.java:237)
        at kaffe.lang.AppClassLoader.<clinit>(AppClassLoader.java:35)
        at java.lang.VMClassLoader.getSystemClassLoader(VMClassLoader.java:293)
        at java.lang.ClassLoader$StaticData.<clinit>(ClassLoader.java:160)
        at java.lang.ClassLoader.getSystemClassLoader(ClassLoader.java:772)
Aborted

-- 
marko