[kaffe] Suspicious changes

Dalibor Topic robilad at kaffe.org
Sat Jul 10 13:00:57 PDT 2004

Dalibor Topic wrote:
> Gwenole Beauchesne wrote:
>> Hi,
>>> While tracking down my regressions on x86_64, I came accross the 
>>> following (unrelated) problem:
>> Turns out to be related, I realized that when I bothered looking at 
>> Hashtable.java:264 as mentioned in the trace and noticed loadFactor 
>> was a "float". ;-)
>>> 2004-03-24  Dalibor Topic <robilad at kaffe.org>
>>>         * kaffe/kaffevm/support.c,
>>>         libraries/clib/net/PlainSocketImpl.c:
>>>         Fixed remaining 'foo' is not defined warnings.
>> I have locally reverted this one and now only 1/144 tests fail:
>> FAIL: TestSerializable2.java
> Yay, same blunder as the previous one. As in the other case, the usage 
> of  PROMOTE_jfloat2double relied on #if 'undefined something' being 
> evaluated to 0. Addiotionally, No_HOLES is now used in a #if 
> defined(NO_HOLES) and #if !NO_HOLES. Ouch. I'll fix it as the GNU coding 
> standard recommends asap.

Fixed in CVS head now. Thanks again for the spot-on bug analysis, Gwenole.

dalibor topic

More information about the kaffe mailing list