[kaffe] Suspicious changes
gbeauchesne at mandrakesoft.com
Thu Jul 8 16:34:42 PDT 2004
While tracking down my regressions on x86_64, I came accross the
following (unrelated) problem:
2004-03-24 Dalibor Topic <robilad at kaffe.org>
Fixed remaining 'foo' is not defined warnings.
which, for this problem, looks like:
@@ -384,7 +384,7 @@ execute_java_constructor(const char* cna
be marked as 'D'. No known port uses this. In fact, alpha must
explicitly set it to 0, to prevent PROMOTE_TO_64bits from enabling
# define PROM_f d
# define PROM_f f
My interpretation of the C standard tells that in "#if FOO", if FOO is
not defined, it will yield 0. Besides, "#if defined(FOO)" will yield
true even if FOO is defined to 0.
Thus, since I had #define PROMOTE_jfloat2jdouble 0 in
config/x86_64/sysdepCallMethod.h, Kaffe will do jfloat to jdouble
promotion, which is not wanted.
I could remove that definition from x86_64 sysdepCallMethod.h, but that
would IMHO still hide the bug that you now check for the macro being
defined instead of its actual value. I believe this is why I see
Double*.java regressions [when using an x86 built rt.jar].
I will have a closer look when I actually fix the remaining issues with
an x86_64 built rt.jar. ;-) For now, I determined the regression
occurred between 2004/03/23 and 2004/03/26.
More information about the kaffe